feat: migrate frontend from Next.js to Vite + React - #3
Merged
Conversation
collinsezedike
added
frontend
collinsezedike
commented
May 9, 2026
collinsezedike
commented
May 9, 2026
collinsezedike
commented
May 9, 2026
collinsezedike
left a comment
collinsezedike
left a comment
Collaborator
Author
There was a problem hiding this comment.
Good migration overall.
The Vite config, ESLint setup, env var renaming, and monorepo plumbing are all handled correctly, and the VaultCard component is a clean addition.
Two things need fixing before this merges: the stale placeholder text in both VaultList and PortfolioSummary is still rendering in the UI, and handleDeposit should be pulled out of the render cycle. The rest of the comments are minor and can be addressed in follow-up PRs if preferred.
| run: | | ||
| stellar contract build | ||
| cargo test | ||
| # Uncomment when packages/contracts has a Cargo.toml |
Collaborator
Author
There was a problem hiding this comment.
Nit: link a tracking issue in this comment so it doesn't get forgotten. Something like # TODO(#X): restore when packages/contracts has a Cargo.toml.
This was referenced May 9, 2026
collinsezedike
added a commit
that referenced
this pull request
May 9, 2026
Updates README, turbo.json, docs/github-issues.md, and scripts/setup-github.sh to reflect the Vite + React migration from PR #3.
collinsezedike
removed
frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Changes
@vitejs/plugin-react)index.html,vite.config.ts,tsconfig.json,tailwind.config.js,postcss.config.cjspages/index.tsx→src/App.tsx+src/main.tsxNEXT_PUBLIC_*env vars withVITE_*pnpm-workspace.yaml; remove unsupportedworkspacesfield from rootpackage.jsonVaultCardcomponent and mock vault/position data