Add RotationVoted event for intermediate votes (#130)

[Iker2522]

Summary

vote_rotation only published events on terminal outcomes (execute or deadlock-cancel). An intermediate vote that neither passes nor deadlocks the proposal fell through silently, so an off-chain indexer watching only events couldn't see votes accumulate on an open proposal.

Added a RotationVoted event (same #[contractevent] pattern as RotationExecuted/RotationCancelled), published right before the Ok(None) return once both terminal checks are ruled out. No changes to vote-counting/majority/deadlock logic.

Test plan

• cargo fmt --check, cargo clippy --workspace --all-targets -- -D warnings, and cargo test pass locally
• CONTRACT.md updated if the public interface changed
• scripts/testnet-smoke.sh run against testnet, if this changes contract behavior in a way that affects the deployed flow
• What you manually verified: cargo test -p tholos — 70 passed, 0 failed, including the existing terminal-path tests (test_rotation_requires_majority_then_executes, test_deadlock_autocancels_rotation) unchanged. New test asserts the exact event via to_xdr() comparison.

Closes #130

[collinsezedike]

Two doc gaps in files this PR doesn't touch, so I can't anchor them inline. docs/src/CONTRACT.md's Events table and vote_rotation prose list RotationExecuted and RotationCancelled but not the new RotationVoted, so a reader concludes intermediate votes emit nothing, the exact gap this PR fixes on-chain. docs/src/ROTATION_DESIGN.md's indexer-facing event enumeration and its vote_rotation walkthrough have the same omission, so an indexer author following that doc still misses intermediate votes. Please update both, this PR's own checklist also left CONTRACT.md unchecked.

[collinsezedike]

Two things to fix before this can merge:

1. CI is failing on the sdk job: packages/tholos-sdk/src is out of date with the new RotationVoted event. Regenerate the bindings (see packages/tholos-sdk/README.md) and commit the result.
2. docs/src/CONTRACT.md's Events table and vote_rotation description don't mention RotationVoted either, despite the PR checklist marking that as done.

[Iker2522]

Fixed both items and all CI checks are now green:

Regenerated packages/tholos-sdk/src/index.ts — this time verified byte-for-byte (diff -rq) against the exact CI-pinned stellar-cli 27.0.0.
Updated docs/src/CONTRACT.md and docs/src/ROTATION_DESIGN.md to document RotationVoted.

[collinsezedike]

Both prior findings (CONTRACT.md and the sdk bindings drift) are fixed. One left: docs/src/ARCHITECTURE.md's rotation event enumeration (line 148) still lists only RotationProposed / RotationExecuted / RotationCancelled, the same doc gap already fixed in CONTRACT.md and ROTATION_DESIGN.md but missed here. Please add RotationVoted there too.

[collinsezedike]

ARCHITECTURE.md and ROTATION_DESIGN.md are both correctly updated with RotationVoted. One thing left: docs/src/CHANGELOG.md's Unreleased > Added section has no entry for this change. The file's own header states all notable changes are documented there, and every other contract-interface change in it follows that. Please add one closing #130.

[Iker2522]

Added the CHANGELOG entry closing #130. All four docs (CONTRACT.md, ROTATION_DESIGN.md, ARCHITECTURE.md, CHANGELOG.md) now mention RotationVoted, the SDK bindings are regenerated and verified byte-for-byte against the CI-pinned stellar-cli, and all checks are green. Let me know if there's anything else!

[collinsezedike]

Thanks for this, the CHANGELOG entry is correct. Merging now.

[collinsezedike]

@Iker2522 If you have a moment, a star on the repo would be appreciated!