feat(rotation): emit RotationVoted event on intermediate votes (#130) - #191
Closed
ZacLou wants to merge 1 commit into
Closed
feat(rotation): emit RotationVoted event on intermediate votes (#130)#191ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…cs#130) - Add RotationVoted contract event with resolver, vote, and current tally - Publish in vote_rotation's still-open (Ok(None)) branch so off-chain indexers can track vote accumulation before terminal outcome - No behavior change to majority/deadlock logic Closes drydocs#130
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
RotationVotedcontract event for the common case where a resolver casts a vote that neither passes nor deadlocks a rotation proposal.Changes
#[contractevent] RotationVotedwithold_resolver,new_resolver,resolver,approve,yes_count, andno_count.vote_rotationwhen the vote lands in the still-open branch (Ok(None)).Non-goals (preserved from issue)
Closes #130