fix(tholos): prevent resolver from voting on their own case (#165) - #198
Closed
ZacLou wants to merge 9 commits into
Closed
fix(tholos): prevent resolver from voting on their own case (#165)#198ZacLou wants to merge 9 commits into
ZacLou wants to merge 9 commits into
Conversation
) resolve() now rejects calls where the resolver is the asserter or the disputer of the assertion they are trying to resolve. Both parties have a direct economic interest in the outcome, so their vote cannot be considered neutral. - Adds Error::ConflictOfInterest = 24 - Checks resolver against assertion.asserter and assertion.disputer before recording the vote Closes drydocs#165
Contributor
Author
|
Fixed the SDK drift: the contract now returns |
ZacLou
force-pushed
the
fix/tholos-resolve-self-vote-165
branch
from
September 6, 2026 06:30
b70cb0f to
331f348
Compare
ZacLou
force-pushed
the
fix/tholos-resolve-self-vote-165
branch
from
September 6, 2026 06:34
331f348 to
76ad8d1
Compare
added 7 commits
September 6, 2026 14:36
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165
Problem
resolvechecked that the caller was a resolver and had not already voted, but never checked whether the resolver was also the assertion’sasserterordisputer. A party to the dispute could vote in their own favor, including the degenerate case of a size-1 committee where a single address acting as both disputer and sole resolver could guarantee their own win.Fix
Error::ConflictOfInterest = 24resolvewhenresolver == assertion.asserterorresolver == assertion.disputerThe check runs after resolver-membership validation but before the vote is recorded, so a self-interested resolver gets a clear error rather than a silent rejection.
Verification