Reclaim stalled dispute - #211
Conversation
…_dispute Cap refunds in reclaim_stalled_dispute against tracked AssertionEscrow balance deltas, preventing contract traps or overpaying from pooled balances. Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…23233312752 fix(tholos): account for fee-on-transfer shortfall in reclaim_stalled_dispute
|
This PR's diff includes a large number of unrelated test snapshots across asserter-consumer, demo-consumer, and tholos-v2 that have nothing to do with this fix, plus a self-merge commit in the history. This looks like a branch mix-up on your end (possibly branched from a stale fork main). Please rebase this onto a fresh branch from drydocs/tholos's actual main so the diff only contains the reclaim_stalled_dispute fix and its own test, this is unreviewable as currently scoped. Separately: this issue explicitly depends on #180's AssertionEscrow mechanism, which is still open with requested changes, not yet merged. Once you've rebased cleanly, make sure your fix builds on top of #180's actual final version rather than reimplementing the escrow tracking separately. |
|
@gloskull Checking in, any progress on rebasing this? Let us know if you're still working it or need to hand it off. |
2 participants
Fixes issue where reclaim_stalled_dispute did not account for fee-on-transfer token shortfalls. Now tracks incoming token deposit balance deltas in AssertionEscrow and caps outgoing refunds in reclaim_stalled_dispute (as well as finalize and resolve) against the actual escrowed amounts. Includes unit test using a fee-on-transfer token mock.
Closes #207