Skip to content

adds ability to fetch details from opencagedata.com request#6

Open
winescout wants to merge 1 commit intodsantosmerino:mainfrom
winescout:master
Open

adds ability to fetch details from opencagedata.com request#6
winescout wants to merge 1 commit intodsantosmerino:mainfrom
winescout:master

Conversation

@winescout
Copy link

I needed to fish out more detail from the API response, so I coded this up. Do you think it's worthy to add to the mainline?

@dsantosmerino
Copy link
Owner

Hey @winescout, thanks for your contribution! I like the idea of adding more interesting info in the response of the library, given that OpenCage gives a lot of data.

I'm thinking if it makes sense to add this in the existing main functions (reverse/geocode) with another parameter that says that you want to expand the response. With this approach, we keep the existing API while opening it with the changes that you proposed to retrieve more information about the location.

What do you think? Do you want to work on this or shall I jump to your branch?

@winescout
Copy link
Author

@dsantosmerino awesome. I went back and forth on the right approach here. Happy to do it that way. Something like: ??

OpenCagex.geocode("Passatge de la Pau, Barcelona", fields: [:timezone, :countrycode])

@gamecubate
Copy link

I need this too ! More specifically, I need a geocode call to also return bounds information for the requested name. This PR is 2 years+ old. Why was this not merged? Has the functionality been added by other means?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants