feat (ProcessBuilder): Implement client side patching for Forge#396
Open
GeekCornerGH wants to merge 9 commits into
Open
feat (ProcessBuilder): Implement client side patching for Forge#396GeekCornerGH wants to merge 9 commits into
GeekCornerGH wants to merge 9 commits into
Conversation
This was referenced May 14, 2026
…d catching error logic to prevent hanging launcher progress
…javaBin for spawning process
2180a1a to
9292ed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing on-launcher jar patching for Minecraft Forge
Motivation
Implementing NeoForge was something I wanted to do since a while. However, Forge (in this case versions based on ForgeGradle3) is currently implemented in a hacky way, which also redistributes a modified verison of the Minecraft Jar. While I'm not aware of any Helios user receiving a DMCA takedown notice, I'm however aware that Mojang's AI used for brand protection (Tracer) is known to send mistaken notices. I know this bot scans GitHub, and I also know quite some users are hosting their distribution files on GitHub as well.
I've also noticed NeoForge and Forge are launched in basically the same way, meaning I'll be able to reuse these changes when implementing NeoForge on a later PR.
Oh, and it probably also supersedes dscalzi/Nebula#65
How it works
How to test
npm linkto add a location to the modified helios-distribution-types, then build the projectsnpm linkto point to helios-core, and start the launcherWarning⚠️
The older distribution files won't be compatible with this modified version of helios, and therefore introduces a breaking change
Relevant PRs
Additional notes
Thanks to @sjempotje for testing and refactoring some code