-
Notifications
You must be signed in to change notification settings - Fork 90
Expose -IncludeHidden parameter #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5b92e69 to
e7848d9
Compare
NetAdapter module Cmdlets have an -IncludeHidden flag which allows access to adapters which are hidden; expose that flag here. - Add flag to MOF schemas - Add function parameter and comment based help - NetAdapterName should now be working - NetAdapterRdma should now be working - NetAdapterRss should now be working - NetAdapterState should now be working
e7848d9 to
bad0489
Compare
Add [Switch]IncludeHidden to mocked Rename-NetAdapter in unit tests
Add [Switch]IncludeHidden to mocked Set-NetAdapterRdma in unit tests
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
===================================
Coverage 97% 97%
===================================
Files 28 28
Lines 2070 2071 +1
===================================
+ Hits 2021 2023 +2
+ Misses 49 48 -1
🚀 New features to boost your workflow:
|
|
@gaelicWizard - this is quite an interesting one. Could you raise an issue for us to discuss it? What I'd like to think about (and open for discussion) is should we just switch the |
Pull Request (PR) description
NetAdapter module Cmdlets have an -IncludeHidden flag which allows access to adapters which are hidden; expose that flag here.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is