Skip to content

xPackage, fixes bug preventing uninstalling software #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raandree wants to merge 16 commits into
base: main
Choose a base branch
from
Open

xPackage, fixes bug preventing uninstalling software #705

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
57e23c8
Fixes #704
raandree Nov 25, 2020
3f4c3e7
Updated changelog
raandree Nov 25, 2020
18f1e24
Trying to satisfy test 'Should correctly install and remove a .exe pa…
raandree Dec 3, 2020
285760c
Fixing style
raandree Dec 3, 2020
4fc38f5
Merge branch 'master' into fix/#704
raandree Dec 6, 2020
aa289c6
Merge branch 'master' into fix/#704
PlagueHO Dec 17, 2020
1b05b74
Update Gitversion to latest pattern (#708)
PlagueHO Jan 20, 2021
6c6c91f
Updated build to use Sampler.GitHubTasks - Fixes #711 (#712)
PlagueHO Apr 10, 2021
dcadffd
Added Code Coverage support to pipeline - Fixes #711 (#714)
PlagueHO Apr 21, 2021
475885c
xRemoteFile: Fix inconsistencies in messages for en-us (#717)
BITespresso May 23, 2021
fbbc6c8
Fixes #704
raandree Nov 25, 2020
93f6d45
Solved merge conflict
raandree May 30, 2021
ac014e5
Trying to satisfy test 'Should correctly install and remove a .exe pa…
raandree Dec 3, 2020
cf2b14f
Fixing style
raandree Dec 3, 2020
8cd4a64
Merge conflict changelog
raandree May 30, 2021
dae9bab
Replacing try with if block
raandree May 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- xPackage
- Uninstalling software (Ensure = Absent) did not work due to improper handling of arguments. This fixes #704.

### Fixed

- xPSDesiredStateConfiguration
Expand Down
17 changes: 3 additions & 14 deletions source/DSCResources/DSC_xPackageResource/DSC_xPackageResource.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,19 +539,8 @@ function Set-TargetResource
else
{
# Absent case
$startInfo.FileName = "$env:winDir\system32\msiexec.exe"

# We may have used the Name earlier, now we need the actual ID
if ($null -eq $productEntry -or $null -eq $productEntry.Name)
{
$id = $Path
}
else
{
$id = Split-Path -Path $productEntry.Name -Leaf
}

$startInfo.Arguments = "/x `"$id`" /quiet /norestart"
$uninstallString = $productEntry.GetValue('UninstallString')
$startInfo.FileName = $uninstallString

if ($LogPath)
{
Expand All @@ -561,7 +550,7 @@ function Set-TargetResource
if ($Arguments)
{
# Append the specified arguments with a space (#195)
$startInfo.Arguments += ' {0}' -f $Arguments
$startInfo.Arguments = " $Arguments"
}
}
}
Expand Down