fix: premuliplied alpha blending#202
Merged
Merged
Conversation
dsh0416
commented
May 24, 2026
dsh0416
commented
Owner
- Display CEF browser textures with premultiplied-alpha blending to avoid color shifts on transparent/antialiased content.
- Apply the same premultiplied-alpha material to accelerated popup overlays.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts how CefTexture (and its accelerated popup overlay) is rendered in Godot by applying premultiplied-alpha blending, aiming to eliminate color fringes/shifts around transparent/antialiased browser content.
Changes:
- Introduces a helper to create a
CanvasItemMaterialconfigured forPREMULT_ALPHAblending. - Applies the premultiplied-alpha material to the main
CefTextureTextureRectduringREADY. - Applies the same premultiplied-alpha material to the accelerated popup overlay
TextureRect.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/gdcef/src/cef_texture/mod.rs | Adds a premultiplied-alpha CanvasItemMaterial helper and assigns it to the main CefTexture node on ready. |
| crates/gdcef/src/cef_texture/rendering.rs | Assigns the premultiplied-alpha material to the accelerated popup overlay TextureRect. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| self.with_app_mut(|app| app.mark_cef_retained()); | ||
|
|
||
| self.base_mut().set_expand_mode(ExpandMode::IGNORE_SIZE); | ||
| self.base_mut().set_material(&Self::make_browser_material()); |
Comment on lines
155
to
+157
| let mut overlay = TextureRect::new_alloc(); | ||
| overlay.set_expand_mode(ExpandMode::IGNORE_SIZE); | ||
| overlay.set_material(&Self::make_browser_material()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.