fix: allow writer functions in property named structures#1412
Open
forivall wants to merge 3 commits intodsherret:latestfrom
Open
fix: allow writer functions in property named structures#1412forivall wants to merge 3 commits intodsherret:latestfrom
forivall wants to merge 3 commits intodsherret:latestfrom
Conversation
dsherret
reviewed
Sep 11, 2023
|
|
||
| export interface PropertyNamedNodeStructure { | ||
| name: string; | ||
| name: string | WriterFunction; |
Owner
There was a problem hiding this comment.
I'm hesitant to merge this because people are likely doing comparisons on string. One of the major issues with structures is that changes that make it easier for writing can make it harder to use for reading. At this point, I think this might be too breaking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1160
Other solutions possible, as mentioned in #1160 comments