Removed run_peer_service_forever function #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
reviewed
Jun 17, 2022
| if args.service: | ||
| verbosity = args.verbosity if (args.verbosity is not None) else 0 | ||
| crawler_thread = spawn_peer_crawler_thread(ctx, True, args.delay, verbosity) | ||
| run_peer_service_forever(crawler_thread.peerman, port=args.port) |
Owner
There was a problem hiding this comment.
The port command line argument can be deleted too
Owner
|
The peer_service_header can be deleted too. |
Owner
|
And probably others too. |
Owner
|
We can't rmeove this code until we add the code that replaces this. |
Owner
|
peercrawlerport can be rmeoved too |
Owner
|
This PR has conflicts that need to be resolved. |
Collaborator
|
@dsiganos I remember we talked previously about making a peer service client. Is it still relevant? |
dsiganos
reviewed
Jun 26, 2022
| do_connect(ctx, args.connect) | ||
| sys.exit(0) | ||
|
|
||
| if args.service: |
Owner
There was a problem hiding this comment.
The whole concept of peercrawler service needs to be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.