-
Notifications
You must be signed in to change notification settings - Fork 145
Cleanup and resubmit several PRs #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+263
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new command and add test_blame test case.
- Allow for the setting of properties via LocalClient.propset() - Fix bug in CommonClient.properties() that caused an exception when proplist had zero entries in it
- Added no_ignore=False option to CommonClient.status(). Setting to true causes --no-ignore option to be passed to svn, so as to include ignored files in the result. - Added tests for 'ignored' and 'unversioned' files.
…ed (svn_uri_is_canonical(url, scratch_pool))
1. Changed split from == to 67 ='s to match the output. Original would break on equality checks in many languages. 2. Improved handling of diff on directories so that the root directory does not cause an exception. 3. Included unit test for the diff change. 4. Added unit test for properties.
Author
|
Travis failed due to failing to install python3.3. Is it always broken? Will it retry? |
544f7da to
230a2cd
Compare
Author
|
Since this doesn't merge cleanly anymore and there was a big diff rewrite, the PRs probably need to be cleaned up again. Cherry picking from this PR might help, but I'm not going to attempt to fix them all again. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes no novel commits. I've taken several of the most promising PRs
(especially those with tests or resolved feedback) and merged them all together. Some of them I've improved by applying your
review feedback.
This PR serves partly as a way to get these PRs submitted, but also as way to share my effort in collecting fixes for myself.
All tests pass for me locally.