Skip to content

Conversation

@idbrii
Copy link

@idbrii idbrii commented Feb 1, 2020

This PR includes no novel commits. I've taken several of the most promising PRs
(especially those with tests or resolved feedback) and merged them all together. Some of them I've improved by applying your
review feedback.

This PR serves partly as a way to get these PRs submitted, but also as way to share my effort in collecting fixes for myself.

All tests pass for me locally.

$ python3 -m unittest 
............../svn/common.py:262: DeprecationWarning: This method will be removed in future versions.  Use 'list(elem)' or iteration over elem instead.
  entry_info = {x.tag: x.text for x in e.getchildren()}
..../svn/common.py:262: DeprecationWarning: This method will be removed in future versions.  Use 'list(elem)' or iteration over elem instead.
  entry_info = {x.tag: x.text for x in e.getchildren()}
...../svn/common.py:262: DeprecationWarning: This method will be removed in future versions.  Use 'list(elem)' or iteration over elem instead.
  entry_info = {x.tag: x.text for x in e.getchildren()}
.....
----------------------------------------------------------------------
Ran 25 tests in 55.991s

OK

ml-bnr and others added 13 commits February 1, 2020 03:09
Add new command and add test_blame test case.
- Allow for the setting of properties via LocalClient.propset()
- Fix bug in CommonClient.properties() that caused an exception when
  proplist had zero entries in it
- Added no_ignore=False option to CommonClient.status(). Setting to true
  causes --no-ignore option to be passed to svn, so as to include
  ignored files in the result.
- Added tests for 'ignored' and 'unversioned' files.
1. Changed split from == to 67 ='s to match the output. Original would
   break on equality checks in many languages.
2. Improved handling of diff on directories so that the root directory
   does not cause an exception.
3. Included unit test for the diff change.
4. Added unit test for properties.
@coveralls
Copy link

Coverage Status

Coverage increased (+6.3%) to 77.75% when pulling a1c68c4 on idbrii:collapse-all-pr into 4055a93 on dsoprea:master.

@idbrii
Copy link
Author

idbrii commented Feb 1, 2020

Travis failed due to failing to install python3.3. Is it always broken? Will it retry?

0.10s$ curl -sSf --retry 5 -o python-3.3.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 404 Not Found
Unable to download 3.3 archive. The archive may not exist. Please consider a different version.

@dsoprea dsoprea force-pushed the master branch 3 times, most recently from 544f7da to 230a2cd Compare February 1, 2020 22:10
@idbrii
Copy link
Author

idbrii commented Apr 30, 2021

Since this doesn't merge cleanly anymore and there was a big diff rewrite, the PRs probably need to be cleaned up again. Cherry picking from this PR might help, but I'm not going to attempt to fix them all again. Closing.

@idbrii idbrii closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants