Add changelist to status entries #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix files in changelists don't appear in status(). Add changelist attribute to status() result. Since `svn status` includes files in changelists, it makes sense for status() to include them as well. Add a field to _STATUS_ENTRY for changelist. Files without a changelist have changelist=None and otherwise changelist is the name of the changelist. Rework the status test to use assertIsNotNone and assertEqual to give better error messages. Invalid filenames produce KeyError and are not None, so checking for None wasn't really preventing errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix files in changelists don't appear in status(). Add changelist
attribute to status() result.
Since
svn statusincludes files in changelists, it makes sense forstatus() to include them as well. Add a field to _STATUS_ENTRY for
changelist. Files without a changelist have changelist=None and
otherwise changelist is the name of the changelist.
Rework the status test to use assertIsNotNone and assertEqual to give
better error messages. Invalid filenames produce KeyError and are not
None, so checking for None wasn't really preventing errors.