Return empty dictionary when file has no properties #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This has some overlap with #121, but it's a smaller fix without merge conflicts. |
Fix dsoprea#89: properties method failed when no props defined When a file has no properties, the xml doesn't contain 'target' and target_elem is None. To conform to the documentation for properties, return an empty dict (instead of None). Test for both no properties and mime type property (writing a binary file in the simplest way I can find that works in py2 and py3).
idbrii
force-pushed
the
fix-89-properties
branch
from
0e8f306 to
9f01114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #89: properties method failed when no props defined
When a file has no properties, the xml doesn't contain 'target' and
target_elem is None. To conform to the documentation for properties,
return an empty dict (instead of None).
Test for both no properties and mime type property (writing a binary
file in the simplest way I can find).
Ran tests with nose2 on WSL and all passed.