increase MAX_READ_CHUNK from 100 to 255 to support more realistic path/command lengths#12
Open
nurturenature wants to merge 1 commit intodsrhaslab:mainfrom
Open
Conversation
…h/command lengths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was testing possibly adding
torn-seqandtorn-opto Jepsen'sjepsen.lazyfsNemesis, and noticed that longer file paths were breaking command parsing:This PR increases
MAX_READ_CHUNKfrom 100 to 255.As any fixed # will be arbitrary, this seemed both adequate and reasonable.
After increasing
MAX_READ_CHUNK, the build and tests continue to pass.Rerunning the Jepsen tests shows successful command parsing:
and a
torn-seqthat was enough to unrecoverably crash the system being tested:If you are willing to accept this PR, would you also be willing to create a new tag/release?
If so, I will work on adding
torn-seqandtorn-opsupport to Jepsen'sjepsen.lazyfsNemesis.Also note that the current latest tag,
0.3.0, doesn't include thetorn-seqandtorn-oprefactor, etc.Thanks!