Skip to content

Conversation

@mmyrte
Copy link

@mmyrte mmyrte commented Jul 1, 2024

Hi @dsval

As mentioned in the thread at jaideep777@05dc5ce, I'd like to contribute to your project with this PR. Some of the changes are a little opinionated, but as the whole devtools/roxygen/pkgbuild toolchain is well established by now, and since apparently you already worked in VS code on this repo, I feel comfortable asking you to consider these changes.

If you feel comfortable with these contributions, I would gladly resolve some further namespace ambiguities, start to add test cases, and remove dead code, either in this PR or a separate one. You decide.

As I mentioned, I err on the side of collaboration, but if you'd rather not bother with PRs, I totally understand. Time is precious.

Best

Jan


Also tagging @jaideep777, even if he might not want to use the R environment.

@jaideep777
Copy link

Hi Jan @mmyrte

These cleanup edits look nice. I just want to say that these changes appear compatible with the changes I have made on the C++ side, so if @dsval decides to merge both our PRs (I havent created mine yet), they will most likely not conflict.

Best,
Jaideep

@mmyrte
Copy link
Author

mmyrte commented Jul 9, 2024

Hi @jaideep777 - yeah, there are a few files that we both touched, like gitignore and such, but I didn't touch actual logic, so a merge shouldn't be painful. I'll be focusing on my proposal for the coming weeks, so likely won't check back here until August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants