Conversation
fkiraly
added
the
maintenance
Collaborator
Author
|
ok, so it fails only on mac. Strange. |
Owner
|
thats unpleasant. looks like a (classic) mac/math library issue. our np.allclose assertion is off by 10^-5 not a huge deal. we might consider allowing this magnitude to be ok |
Collaborator
Author
|
I would suggest we merge it and keep the failing tests in mind until the next release. Why: next priority is going to be to fix this, and we can check if any of the fixes in the PR tracker addresses this, e.g., #366 - by merging from main, the tests on macos will run on that PR, or any other, and we can see if they fix it |
Owner
|
i like that idea. |
dswah
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement Pr to CI: extends test matrix to ubuntu, macos, windows, python 3.9-3.13. Removes deprecated python 3.8 version.