Skip to content

[MNT] CI job to run notebook examples#402

Merged
dswah merged 8 commits into
dswah:mainfrom
fkiraly:notebook-runner-ci
Dec 25, 2025
Merged

[MNT] CI job to run notebook examples#402
dswah merged 8 commits into
dswah:mainfrom
fkiraly:notebook-runner-ci

Conversation

@fkiraly

@fkiraly fkiraly commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

Adds a CI job to run notebook examples.

Also contains fixes to missing imports in the notebooks.

This should prevent missing datasets such as in #401, also see #423

Depends on #424 which should be merged first.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Nov 8, 2025
@dswah dswah closed this Nov 17, 2025
@dswah dswah reopened this Nov 17, 2025
@dswah dswah closed this Nov 17, 2025
@dswah dswah reopened this Nov 17, 2025
@dswah

dswah commented Nov 17, 2025

Copy link
Copy Markdown
Owner

@fkiraly looks like the bash script needs execution privileges at least. Can you fix?

@fkiraly

fkiraly commented Dec 23, 2025

Copy link
Copy Markdown
Collaborator Author

fixed - but now the code does not seem to be able to find the wage.csv. Any ideas?

@dswah

dswah commented Dec 24, 2025

Copy link
Copy Markdown
Owner

@fkiraly i will try a local install to narrow down if pygam is being distributed without CSV files, or if UV is not installing them...

@dswah

dswah commented Dec 24, 2025

Copy link
Copy Markdown
Owner

OK, neither local UV nor PIP installs include the datasets... perhaps they are not being distributed?

@dswah

dswah commented Dec 24, 2025

Copy link
Copy Markdown
Owner

OK, neither local UV nor PIP installs include the datasets... perhaps they are not being distributed?

@fkiraly indeed, inspecting the TAR.gz on pypi shows that the dataets CSVs are not included

@fkiraly

fkiraly commented Dec 25, 2025

Copy link
Copy Markdown
Collaborator Author

hm, then I see multple issues:

  • the datasets are not included
  • the data loaders are not covered by tests
  • I thought adding all csv to the setuptools package-data would fix the issue?
    pygam = [
    - but apparently not

@fkiraly

fkiraly commented Dec 25, 2025

Copy link
Copy Markdown
Collaborator Author

opened an issue here: #423

@fkiraly

fkiraly commented Dec 25, 2025

Copy link
Copy Markdown
Collaborator Author

@dswah, ready to review again. #424 should be merged first.

@dswah

dswah commented Dec 25, 2025

Copy link
Copy Markdown
Owner

@fkiraly this is great!!
good job figuring out the packaging. merging...

@dswah dswah merged commit eb26725 into dswah:main Dec 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants