fix: Core.get_params() exposing internal state via self.__dict__ (#521)#527
Closed
dkstlzk wants to merge 2 commits into
Closed
fix: Core.get_params() exposing internal state via self.__dict__ (#521)#527dkstlzk wants to merge 2 commits into
Core.get_params() exposing internal state via self.__dict__ (#521)#527dkstlzk wants to merge 2 commits into
Conversation
Owner
|
hi this PR does not do what the description says. closing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #521.
Core.get_params(deep=True) previously returned
self.__dict__,which exposed the estimator's internal attribute storage directly. This allowed external mutation of the estimator state when modifying the returned dictionary.This change returns a shallow copy instead, preventing external mutation while preserving existing behavior.