Open
Conversation
|
This is impeccable timing as I was just trying to implement C++ callbacks called from Rust. |
|
Hey all! Is there a status update on this feature? |
|
Hello everyone, is this feature going to be merged. ? :) @dtolnay @paandahl We are looking into CXX at https://easymile.com/ and we'd love to use it and possibly contribute if there are things we can do. Thanks! |
|
It has been a few months and just wanted to check if there was any update. This would be super helpful. |
|
The conflicts prevent testing this. Is there a chance we can get the conflicts sorted? @paandahl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put this up as a draft to get feedback; the code still needs cleanup / documentation.
I have added support for
std::function, with the following interface:Usage from C++:
Explanation
The
CxxFunction<A, R>takes two template arguments.A- the arguments. Can be one of:R- the return type.If
Ais a tuple struct, the contents will be spread out, so that each element will match a function argument. The tuple struct itself evaporates at the language boundary.The callback can also be passed by value, wrapped in a UniquePtr.
Rationale
I wanted the API to resemble those of CxxVector, UniquePtr, etc. The tuple struct is not ideal, but necessary to allow for multiple arguments.
I considered looking into a wrapper that would expose the callback as a Fn trait object, but that seems out of line with the rest of the API.
Possible improvements
Discussion
How was this functionality imagined? Is this the way to go, or are there better ways to solve the problem at hand?
Closes: #52