Cover top-level BUILD.bazel + MODULE.bazel in mdbook Bazel chapter.#1679
Open
anforowicz wants to merge 1 commit intodtolnay:masterfrom
Open
Cover top-level BUILD.bazel + MODULE.bazel in mdbook Bazel chapter.#1679anforowicz wants to merge 1 commit intodtolnay:masterfrom
BUILD.bazel + MODULE.bazel in mdbook Bazel chapter.#1679anforowicz wants to merge 1 commit intodtolnay:masterfrom
Conversation
This commit is motivated by the discussion in dtolnay#1676. Including the top-level `BUILD.bazel` will hopefully help to hightlight how the same `version` is used across `cxxbridge`, `cxxbridge-macro`, and `cxx` targets.
Contributor
It all matches, but the Bazel CXX docs leave this part unexplained: I wish the cxxbridge command came as a separate target alongside "cxx" and "cxx_cc", which all works fine. Then, the version numbers would always match. |
Contributor
Author
Ack. After this PR the docs will cover Lines 23 to 27 in 2901aa8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL?
The mdbook
{{#include ...}}syntax is based on what I found in https://rust-lang.github.io/mdBook/format/mdbook.html#including-portions-of-a-file. I tested manually by runningDISPLAY=:20 mdbook build -ounderbook/and looking at the Bazel chapter.I don't really use Bazel often, but I hope that including a more complete example helps. Not sure if a more canonical/reusable example is possible - I hope that Bazel experts if any can chime in with additional/future PRs if needed.
I understand that this PR probably doesn't directly help the reporter of #1676 (since they have more of a custom setup with an ad-hoc
rust_binarytarget forcxxbridge-cmdand withcxxbridge-macrodefined somewhere else (hopefully with a matching version).