Support #[cxx_name = "operator+="], etc. (i.e. not just C identifiers).#1689
Open
anforowicz wants to merge 2 commits intodtolnay:masterfrom
Open
Support #[cxx_name = "operator+="], etc. (i.e. not just C identifiers).#1689anforowicz wants to merge 2 commits intodtolnay:masterfrom
anforowicz wants to merge 2 commits intodtolnay:masterfrom
Conversation
Before this commit, `cxx` wouldn't detect the problem, and later the C++ compilation would fail. After this commit, the error is detected early. This commit seems desirable on its own, but it also helps to build scaffolding for enabling additional checks in follow-up commits (e.g. allowing `operator==` for function names, but not for other `[cxx::bridge]` API names).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL?
This came up in https://crrev.com/c/7253816/comment/3f283bcf_9ab0850a/
and in #109 (comment)
Some additional notes:
check_reserved_nametocheck_type_namein the 1st commit, because 1) it is called only for type names, and 2) in the 1st commit I also introducecheck_nameand in the 2nd commitcheck_fn_namereport_errorin the newfn check_nameI kind of lie when callingtokens.set_span(the span of#[cxx_name...]'s arg is not the same as the span of the ident). But it seems to work ok for error reporting, so hopefully this is fine.