Extend the book's async page to show multiple calls to rust::Fn producing a stream#861
Open
jerel wants to merge 2 commits intodtolnay:masterfrom
Open
Extend the book's async page to show multiple calls to rust::Fn producing a stream#861jerel wants to merge 2 commits intodtolnay:masterfrom
jerel wants to merge 2 commits intodtolnay:masterfrom
Conversation
dtolnay
requested changes
Aug 7, 2025
Comment on lines
+104
to
+106
| done(*ctx, std::move(res)); | ||
| done(*ctx, std::move(res)); | ||
| done(*ctx, std::move(res)); |
Owner
There was a problem hiding this comment.
Are you able to share some code structure that is more illustrative of how these res values would be obtained asynchronously in C++? As is, this example looks like it is just synchronously sending 3 values, which would not make sense to treat as futures::Stream in Rust. And something like co_await arg->next() does not work because this function is not a coroutine.
I am not familiar enough with streaming APIs in C++ to tell from this example how it would translate to usable real-world code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented in #856 this is a small edit to the async page to show returning streaming values by repeatedly executing a
rust::FnIf you don't feel like this would fit in with the goals of the book feel free to reject it. I thought I'd open the PR since having this myself would have helped me connect some dots of how the interaction between Rust and C++ works.