feat: add possibility to check against hashed keys#4
Draft
thpiron wants to merge 1 commit intodtomlinson91:mainfrom
Draft
feat: add possibility to check against hashed keys#4thpiron wants to merge 1 commit intodtomlinson91:mainfrom
thpiron wants to merge 1 commit intodtomlinson91:mainfrom
Conversation
Signed-off-by: Thibault Piron <thibault.a.piron@gmail.com>
Owner
|
@thpiron apologies i've taken so long to get back to you on this, i'll have a look tomorrow and we can merge this in 👍 |
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this is a draft PR for hashed keys. I'm open to suggestions/improvements.
I added a way to very simply cache hashed key because bcrypt checking can be very slow (by bcrypt design itself).
Supporting bcrypt and sha1 for now, as htpasswd md5 based algorithm seems painful to replicate.
If it looks good enough for you I'll add some tests.