Erlangian receives#55
Merged
Merged
Conversation
ecpeterson
marked this pull request as ready for review
September 3, 2025 17:26
ecpeterson
commented
Sep 3, 2025
ecpeterson
commented
Sep 3, 2025
ecpeterson
commented
Sep 3, 2025
karalekas
requested changes
Sep 9, 2025
karalekas
left a comment
karalekas
left a comment
Member
There was a problem hiding this comment.
testing looks good, thanks for doing this -- i approve pending the docstring updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks
receive-messageand friends (mostly:message-dispatchinprocess.lisp) to traverse the message queue in its outer loop and the receive clauses in its inner loop.Erlang uses this other order, but mainline aether outer-traverses clauses and inner-traverses all messages in a mailbox. I think Erlang is "right": it is insensitive to the Lamport ordering between a simultaneous (timeout-free)
receiveand an inbound message enqueues into the inbox, whereas aether's is sensitive.Happily, we seem to always want our algorithms to be insensitive to this, so we've implemented those defensively and they seem to Just Work in this new setting.
This probably deserves a (minor?) version bump.