fix message-RTS clause of sync-rpc#57
Merged
Merged
Conversation
Contributor
Author
|
Closes #56 . |
karalekas
self-requested a review
September 9, 2025 01:42
karalekas
approved these changes
Sep 9, 2025
karalekas
left a comment
karalekas
left a comment
Member
There was a problem hiding this comment.
testing looks good, thanks for doing this
karalekas
changed the title
message-RTS clause of sync-rpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On main, sync-rpc encountering a message-RTS causes it to set the returned? flag high and then exit the command, never passing control to the caller body to do anything with the flag. This bug has presumably been here since before we realized we needed to wrap the bodies of sync commands for use as a callback — so, 5 years or so.
I'm not sure this is the nicest possible fix. Certainly it doesn't work with all possible unpack lambda lists.