Skip to content

Feature/service and testing update #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pkly merged 18 commits into from
Apr 22, 2024
Merged

Feature/service and testing update #18

pkly merged 18 commits into from
Apr 22, 2024

Conversation

@pkly
Copy link
Member

@pkly pkly commented Apr 19, 2024 •
edited
Loading

Fixes #14

@github-actions
Copy link

github-actions bot commented Apr 19, 2024

Code Coverage

Package Line Rate Health
Attributes/Event.php 50% ❌
Attributes/PostPersistEvent.php 0% ❌
Attributes/PostRemoveEvent.php 0% ❌
Attributes/PostUpdateEvent.php 0% ❌
Attributes/PrePersistEvent.php 0% ❌
Attributes/PreRemoveEvent.php 0% ❌
Attributes/PreUpdateEvent.php 0% ❌
Attributes/SubEvent.php 100% ✔
DependencyInjection/CompilerPass/EventDetectionCompilerPass.php 52% ❌
DependencyInjection/Configuration.php 100% ✔
DependencyInjection/DoctrineEventConverterExtension.php 100% ✔
DependencyInjection/Model/AbstractEventConfiguration.php 67% ➖
DependencyInjection/Model/EventConfiguration.php 0% ❌
DependencyInjection/Model/SubEventConfiguration.php 85% ✔
DoctrineEventConverterBundle.php 85% ✔
Event/AbstractEntityEvent.php 75% ➖
Event/DispatchEvent.php 100% ✔
EventSubscriber/DispatchingSubscriber.php 100% ✔
Exception/AbstractEventDistributorException.php 100% ✔
Exception/DependencyInjection/AbstractEntityEventNotExtendedException.php 0% ❌
Exception/DependencyInjection/EntityInterfaceMissingException.php 0% ❌
Exception/DependencyInjection/NoValidEntityFoundException.php 0% ❌
Exception/DependencyInjection/SubEventNameCollisionException.php 0% ❌
Exception/DependencyInjection/SubEventRequiredFieldsException.php 0% ❌
Exception/DependencyInjection/TargetClassFinalException.php 0% ❌
Exception/DependencyInjection/UnknownEventTypeException.php 0% ❌
Exception/Proxy/DirectoryNotWritable.php 0% ❌
Exception/Proxy/NotProxyClassException.php 0% ❌
Exception/Proxy/TargetClassFinalException.php 0% ❌
Exception/Proxy/TargetClassNamingSchemeInvalidException.php 0% ❌
Interfaces/EntityInterface.php 0% ❌
Interfaces/MainEventInterface.php 0% ❌
Interfaces/SubEventInterface.php 0% ❌
Model/Change.php 100% ✔
Model/Event.php 100% ✔
Model/SubEvent.php 100% ✔
Model/Undefined.php 0% ❌
Proxy/Generator.php 36% ❌
Service/DelayableEventDispatcher.php 70% ➖
Service/EventService.php 89% ✔
Service/SubEventService.php 100% ✔
Service/VerifierService.php 89% ✔
Summary 69% (291 / 424) ➖

Minimum allowed line rate is 65%

kamilbarth
kamilbarth reviewed Apr 19, 2024
View reviewed changes
@pkly pkly merged commit 3531f18 into master Apr 22, 2024
@pkly pkly deleted the feature/service-and-testing-update branch April 22, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kamilbarth kamilbarth kamilbarth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor subevent logic into a separate service + tests

3 participants

@pkly @kamilbarth