Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
steven-tey
approved these changes
Dec 12, 2024
devkiran
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
TimeSeriesChart,FunnelChart, and related components into@dub/ui/charts.This requires updating
tsup.config.tsandpackage.jsonwith separate entry points for@dub/uiand@dub/ui/charts. Because this breaks all of the places we currently have@dub/ui/src/...(which are mostly icon imports), I also added a new entry point for@dub/ui/icons, and ideally we'll remove the icons from the root@dub/uiin the future.This PR also adds
defaultTooltipIndextoTimeSeriesChartanddefaultTooltipStepIdtoFunnelChartso we can choose to display default tooltips when nothing is hovered, which may be useful for the marketing site.