fix(tag-selection): fix tag deselection crash in link editing#1813
Closed
ThisChirag wants to merge 4 commits intodubinc:mainfrom
Closed
fix(tag-selection): fix tag deselection crash in link editing#1813ThisChirag wants to merge 4 commits intodubinc:mainfrom
ThisChirag wants to merge 4 commits intodubinc:mainfrom
Conversation
Fixes dubinc#1810: Resolve an issue where removing a tag during link editing caused the website to crash. This fix prevents invalid states when all tags are deselected. Tested scenarios: - Tag removal and re-selection. - Removing all tags and re-adding. - No crashes or UI errors when editing links. Signed-off-by: Chirag Sharma <er.chiragsharma.atemail@gmail.com>
Contributor
|
@ThisChirag is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks for the PR! Can you outline specific steps for reproducing the original error? |
Author
Thank you for reviewing the PR. Here's how to reproduce the original error:
Expected Behavior:
Observed Behavior:
This fix ensures that invalid states (such as an empty tag state) are handled properly, preventing the crash. Let me know if any specific details are required. |
Collaborator
|
This should be fixed now 🙏 but let us know if you're still running into this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The issue #1810 was marked as resolved but i'm still facing the same issue:
"Removing the only tag during link editing still causes the website to crash."
Solution
This fix ensures:
Testing
References #1810