fix(create-tag): fix issue where save button remains disabled after creating a new tag.#1814
Closed
ThisChirag wants to merge 3 commits intodubinc:mainfrom
Closed
fix(create-tag): fix issue where save button remains disabled after creating a new tag.#1814ThisChirag wants to merge 3 commits intodubinc:mainfrom
ThisChirag wants to merge 3 commits intodubinc:mainfrom
Conversation
…reating a new tag Resolves the issue where creating a new tag in the "Tags" field while editing a URL did not activate the "Save Changes" button (dubinc#1781). This fix includes: - The form's state is marked as dirty (`shouldDirty: true`) when a new tag is added. - Rollback logic is introduced to restore the previous state if new tag creation fails. Testing included: - Ensuring the "Save Changes" button becomes clickable after creating and assigning a new tag. - rollback and error handling. Fixes dubinc#1781 Signed-off-by: Chirag Sharma <er.chiragsharma.atemail@gmail.com>
Contributor
|
@ThisChirag is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Closing this in favor of #1823, but thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating a new tag in the "Tags" field while editing a URL did not activate the "Save Changes" button (#1781).
Solution
This fix includes:
shouldDirty: true) when a new tag is added.Testing
Testing included:
Fixes #1781