Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage responsive update and fixes #2066

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

marcusljf
Copy link
Collaborator

  • Ensured the short link doesn't overlap with the analytics data values on the right
  • When the percentage is shown on hover, the short link overflow size changes to ensure there is no overlap
  • Fixed an issue found in which the color bars were not filling the entire row based on their actual percentage and would stop at the values, so when hovering it would make the bar smaller. Confusing when the value was 100%. Now fills the container based on actual percentage.

- Ensured the short link doesn't overlap with the analytics data values on the right
- When the percentage is shown on hover, the short link overflow size changes to ensure there is no overlap
- Fixed an issue found in which the color bars were not filling the entire row based on their actual percentage and would stop at the values, so when hovering it would make the bar smaller. Confusing when the value was 100%. Now fills the container based on actual percentage.
@marcusljf marcusljf requested a review from steven-tey February 21, 2025 18:21
Copy link

vercel bot commented Feb 21, 2025

@marcusljf is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dub ✅ Ready (Inspect) Visit Preview Feb 21, 2025 6:34pm

@steven-tey steven-tey merged commit 538b3e3 into dubinc:main Feb 21, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants