Use hex encoding for encodeKeyIfCaseSensitive#3326
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughEncode/decode for link keys changed from base64 to lowercased hex with an "h:" prefix; decoding now supports both formats. New domain-aware helpers were added to conditionally encode/decode keys and reconstruct links for case-sensitive domains. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @apps/web/tests/redirects/index.test.ts:
- Line 19: Remove the debug console.log({baseUrl: h.baseUrl}) line from the test
(index.test.ts): delete that console.log call that references h.baseUrl so the
test output is clean, then run the test suite to confirm no residual debug
logging remains.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/tests/redirects/index.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
| const h = new IntegrationHarness(); | ||
|
|
||
| test("root", async () => { | ||
| console.log({baseUrl: h.baseUrl}) |
There was a problem hiding this comment.
Remove debug console.log statement.
This console.log appears to be a debug artifact that should be removed before merging. It clutters test output without providing value in the production test suite.
🧹 Proposed fix
test("root", async () => {
- console.log({baseUrl: h.baseUrl})
-
const response = await fetch(h.baseUrl, fetchOptions);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| console.log({baseUrl: h.baseUrl}) | |
| test("root", async () => { | |
| const response = await fetch(h.baseUrl, fetchOptions); |
🤖 Prompt for AI Agents
In @apps/web/tests/redirects/index.test.ts at line 19, Remove the debug
console.log({baseUrl: h.baseUrl}) line from the test (index.test.ts): delete
that console.log call that references h.baseUrl so the test output is clean,
then run the test suite to confirm no residual debug logging remains.
Summary by CodeRabbit
New Features
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.