Fix direct sale tracking leadEventData

[steven-tey]

Summary by CodeRabbit

Bug Fixes

• Improved sale conversion tracking to capture more complete data from click events, enhancing conversion attribution accuracy.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
dub	Ready	Preview	Jan 25, 2026 6:43am

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies trackSale to spread all fields from clickData into leadEventData instead of only setting the link_id field. This changes how click and lead event data are merged when a lead event already exists, potentially adding or overriding multiple fields in the resulting leadEventData object.

Changes

Cohort / File(s)	Summary
Click Data Merge apps/web/lib/api/conversions/track-sale.ts	Changed leadEventData composition to merge all clickData fields via spread operator instead of only assigning clickData.link_id

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Allow automatic lead event creation in track/sale #2818: Modifies the same file with related changes to how leadEventData is derived from click data
• Skip processing for zero or negative sale amounts #3108: Adjusts clickData handling in track-sale.ts for sale attribution logic
• Add lead params to /track/sale/client #2822: Updates route to pass additional lead-related fields into trackSale, which connects to how click data is now merged into leadEventData

Suggested reviewers

• devkiran

Poem

🐰 A spread of click data flows so free,
Into the lead event, harmoniously!
No more just link_id's lonely call,
All fields now merge—the grandest haul! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main change: fixing direct sale tracking's leadEventData handling, which aligns with the code change merging clickData fields into leadEventData.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}