Skip to content

Double border and visual changes#3410

Merged
steven-tey merged 1 commit intomainfrom
application-insert-field
Feb 3, 2026
Merged

Double border and visual changes#3410
steven-tey merged 1 commit intomainfrom
application-insert-field

Conversation

@marcusljf
Copy link
Collaborator

@marcusljf marcusljf commented Feb 3, 2026

Insert Field had some double borders happening on the visuals because they were on the SVGs. These have been removed and updated images for the image uploader, website and socials fields.

CleanShot 2026-02-03 at 13 47 34@2x

Summary by CodeRabbit

Style

  • Updated form field preview thumbnail designs with refreshed icon artwork, enhanced canvas sizing, and refined background styling for improved visual clarity and consistency across all form field types.

Insert Field had some double borders happening on the visuals because they were on the SVGs. These have been removed and updated images for the image uploader, website, and socials.
@vercel
Copy link
Contributor

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dub Ready Ready Preview Feb 3, 2026 9:55pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Five SVG thumbnail components in the partner application form design system are updated. Two components (ImageUploadFieldThumbnail, WebsiteAndSocialsFieldThumbnail) are redesigned with larger dimensions (171x100) and new artwork. Three components (MultipleChoiceFieldThumbnail, SelectFieldThumbnail, ShortTextFieldThumbnail) have background rectangles removed. No functional logic or API changes.

Changes

Cohort / File(s) Summary
SVG Redesigns
apps/web/ui/partners/groups/design/application-form/modals/image-upload-field-modal.tsx, apps/web/ui/partners/groups/design/application-form/modals/website-and-socials-field-modal.tsx
SVG dimensions enlarged from 48x48 to 171x100 with updated viewBox. Wrapper class changed from "size-full p-4" to "h-auto w-full". Thumbnail artwork substantially rewritten with new rounded-rect shapes, paths, clip-path infrastructure, and visual styling while preserving component structure.
Background Removal
apps/web/ui/partners/groups/design/application-form/modals/multiple-choice-field-modal.tsx, apps/web/ui/partners/groups/design/application-form/modals/select-field-modal.tsx, apps/web/ui/partners/groups/design/application-form/modals/short-text-field-modal.tsx
Removed white-filled and gray-stroked background rectangles from SVG thumbnails, eliminating the visible background layer while retaining all other SVG content.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • dubinc/dub#3399: Modifies the same thumbnail SVG components (ImageUploadFieldThumbnail, WebsiteAndSocialsFieldThumbnail, and other field modals) with visual design updates.

Suggested reviewers

  • steven-tey

Poem

🐰 Thumbnails dancing, pixels bright,
SVG shapes reshaped just right,
Background curtains drawn away,
New designs now have their say,
From tiny icons to grand display!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Double border and visual changes' accurately summarizes the main objective of the PR, which is to fix double borders in SVG assets and update visual components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch application-insert-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey steven-tey merged commit bc15db4 into main Feb 3, 2026
10 of 12 checks passed
@steven-tey steven-tey deleted the application-insert-field branch February 3, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants