Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis pull request removes PostHog analytics integration from the web application. PostHog imports and event capture calls are deleted across multiple components and files. The PostHog provider is removed from the root provider composition. The posthog-js dependency is removed from package.json. One component (upgrade-plan-button.tsx) gains behavioral changes around stripeId handling. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/ui/workspaces/upgrade-plan-button.tsx (1)
70-80:⚠️ Potential issue | 🔴 CriticalFix the mismatch between client-side and server-side upgrade logic.
The condition on line 72 (
!stripeId || currentPlan === "free") does not align with the server-side endpoint's decision logic. The server returns{ url }whenworkspace.stripeId && activeSubscriptionexists, but the client expects{ url }whenstripeId && currentPlan !== "free". These conditions differ:
- If a workspace has
stripeIdbut no active subscription (e.g., canceled), the server returns{ id }but the client expects{ url }, causingrouter.push(undefined).- If a workspace is on the "free" plan but has an active subscription, the server returns
{ url }but the client expects{ id }, causingstripe.redirectToCheckout({ sessionId: undefined }).Either align the client condition to match the server's
activeSubscriptioncheck, or update the server logic to checkcurrentPlaninstead.
🧹 Nitpick comments (1)
apps/web/ui/modals/link-builder/og-modal.tsx (1)
168-170: Remove unused parameters for consistency with the title completion handler.The
(_, __)parameters are leftover from the removedposthog.capturecall. The title completion'sonFinishon line 122 already uses the cleaner() =>form.Suggested fix
- onFinish: (_, __) => { + onFinish: () => { mutate(); },
Summary by CodeRabbit
Release Notes
Chores
Refactor