Show the program destination URL in the marketplace#3455
Conversation
Instead of the partner searching the web for the company, we should the domain of the group destination URL from the default link settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a conditional Website block to the marketplace program page that renders a truncated external link using Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@apps/web/app/`(ee)/partners.dub.co/(dashboard)/programs/marketplace/[programSlug]/page.tsx:
- Line 132: The label spans for "Rewards" and "Category" currently use a
hardcoded className "block text-xs font-medium text-neutral-400" which doesn't
adapt to dark header images; update those span elements (the label elements
surrounding "Rewards" and "Category") to conditionally apply the inverted text
color when isDarkImage is true (matching how the adjacent value components like
ProgramCategory apply "text-content-inverted")—use the same conditional class
logic or classNames helper used elsewhere so labels switch between
"text-neutral-400" and "text-content-inverted" based on isDarkImage to preserve
contrast.
🧹 Nitpick comments (1)
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/marketplace/[programSlug]/page.tsx (1)
188-212: Website section looks good overall; minor nit on duplicate external-link indicators.Both a
Hyperlinkicon (Line 208) and a↗text arrow (Line 209) signal "external link." Consider dropping one for a cleaner appearance—though this is purely cosmetic.
Instead of the partner searching the web for the company, we'll show the domain of the group destination URL from the default link settings. Also strips additional paths if any are added to keep things simple.
Summary by CodeRabbit
New Features
UI Improvements