Skip to content

Bug: Single link pages with extra height #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcusljf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug: Single link pages with extra height #3463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ function LinkBuilder({ link }: { link: ExpandedLinkProps }) {
const [isChangingLink, setIsChangingLink] = useState(false);

return (
<div className="flex min-h-[calc(100vh-8px)] flex-col rounded-t-[inherit] bg-white">
<div className="flex min-h-[calc(100dvh-var(--page-top-margin)-var(--page-bottom-margin)-1px)] flex-col rounded-t-[inherit] bg-white">
<div className="py-2 pl-4 pr-5">
<LinkBuilderHeader
onSelectLink={(selectedLink) => {
Expand Down Expand Up @@ -308,7 +308,7 @@ const Controls = memo(({ link }: { link: ExpandedLinkProps }) => {

function LoadingSkeleton() {
return (
<div className="flex min-h-[calc(100vh-8px)] flex-col rounded-t-[inherit] bg-white">
<div className="flex min-h-[calc(100dvh-var(--page-top-margin)-var(--page-bottom-margin)-1px)] flex-col rounded-t-[inherit] bg-white">
<div className="flex items-center justify-between gap-4 py-2.5 pl-4 pr-5">
<div className="h-8 w-64 max-w-full animate-pulse rounded-md bg-neutral-100" />
<div className="h-7 w-32 max-w-full animate-pulse rounded-md bg-neutral-100" />
Expand Down
4 changes: 2 additions & 2 deletions apps/web/app/app.dub.co/(dashboard)/[slug]/links/[...link]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import { LinkPageClient } from "./page-client";
export default function LinkPage() {
return (
<PageContentOld
className="md:mt-0 md:bg-transparent md:py-0"
contentWrapperClassName="pt-0 md:rounded-tl-2xl"
className="h-full min-h-full md:mt-0 md:flex md:flex-col md:bg-transparent md:py-0"
contentWrapperClassName="h-full grow pt-0 md:rounded-tl-2xl"
>
<LinkPageClient />
</PageContentOld>
Expand Down
2 changes: 1 addition & 1 deletion apps/web/ui/links/link-builder/link-action-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function LinkActionBar({ children }: PropsWithChildren) {
return (
<div
className={cn(
"sticky bottom-0 w-full overflow-hidden lg:bottom-4 lg:[filter:drop-shadow(0_5px_8px_#222A351d)]",
"sticky bottom-0 z-10 w-full overflow-hidden lg:bottom-4 lg:[filter:drop-shadow(0_5px_8px_#222A351d)]",
)}
>
<div
Expand Down