Skip to content

Format icon component usage and nucleo icon definitions - #4142

Merged
devkiran merged 1 commit into
mainfrom
format
Jul 8, 2026
Merged

Format icon component usage and nucleo icon definitions#4142
devkiran merged 1 commit into
mainfrom
format

Conversation

@devkiran

@devkiran devkiran commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Style
    • Improved visual consistency across the app by standardizing icon and checkmark formatting in multiple UI screens and badges.
    • Updated several SVG icons and status indicators for cleaner, more maintainable rendering code without changing what users see.
    • Refined wording layout in a partner search field description for clearer structure.

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dub Ready Ready Preview Jul 8, 2026 10:29am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87c145ea-ab71-4a3b-8fdc-9236b3989eb0

📥 Commits

Reviewing files that changed from the base of the PR and between 70d36b4 and 1e90739.

📒 Files selected for processing (36)
  • apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/fraud/review-fraud-alert-sheet.tsx
  • apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/trusted/page.tsx
  • apps/web/app/(ee)/app.dub.co/(new-program)/[slug]/program/new/rewards/form.tsx
  • apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submission-fields.tsx
  • apps/web/app/(ee)/partners.dub.co/(apply)/[programSlug]/(default)/apply/success/page.tsx
  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/links/add-edit-group-additional-link-modal.tsx
  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/links/group-link-settings.tsx
  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/network-partner-card.tsx
  • apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/program/reward/form.tsx
  • apps/web/lib/zod/schemas/partners.ts
  • apps/web/ui/integrations/integration-status-badge.tsx
  • apps/web/ui/modals/link-conversion-tracking-modal.tsx
  • apps/web/ui/partners/bounties/bounty-social-content.tsx
  • apps/web/ui/partners/discounts/add-edit-discount-sheet.tsx
  • apps/web/ui/partners/fraud-risks/partner-risk-indicator.tsx
  • apps/web/ui/partners/partner-network/partner-network-status-badge.tsx
  • apps/web/ui/partners/partner-platform-card.tsx
  • apps/web/ui/shared/password-requirements.tsx
  • packages/ui/src/card-selector.tsx
  • packages/ui/src/combobox/index.tsx
  • packages/ui/src/icons/nucleo/bolt.tsx
  • packages/ui/src/icons/nucleo/book2.tsx
  • packages/ui/src/icons/nucleo/bullet-list.tsx
  • packages/ui/src/icons/nucleo/circle-check.tsx
  • packages/ui/src/icons/nucleo/circle-play.tsx
  • packages/ui/src/icons/nucleo/connected-dots.tsx
  • packages/ui/src/icons/nucleo/cube-settings.tsx
  • packages/ui/src/icons/nucleo/diamond-turn-right.tsx
  • packages/ui/src/icons/nucleo/envelope.tsx
  • packages/ui/src/icons/nucleo/gift.tsx
  • packages/ui/src/icons/nucleo/heart.tsx
  • packages/ui/src/icons/nucleo/life-ring.tsx
  • packages/ui/src/icons/nucleo/lock.tsx
  • packages/ui/src/icons/nucleo/msgs.tsx
  • packages/ui/src/icons/nucleo/star.tsx
  • packages/ui/src/icons/nucleo/users.tsx

📝 Walkthrough

Walkthrough

This PR consists entirely of code formatting changes. JSX props for icon components (BadgeCheck2, CircleCheck, Bolt, Flag, CheckboxIcon) are reformatted from single-line to multi-line layouts across various pages and components. SVG attribute markup inside nucleo icon files is similarly reflowed, and a Zod schema description string is split across multiple lines. No logic, props values, or behavior changed.

Changes

Icon JSX and SVG Formatting

Layer / File(s) Summary
Verified badge JSX reformatting
apps/web/app/(ee)/admin.dub.co/.../review-fraud-alert-sheet.tsx, apps/web/app/(ee)/admin.dub.co/.../trusted/page.tsx, apps/web/app/app.dub.co/.../network-partner-card.tsx, apps/web/ui/integrations/integration-status-badge.tsx, apps/web/ui/partners/partner-network/partner-network-status-badge.tsx, apps/web/ui/partners/partner-platform-card.tsx
BadgeCheck2 JSX elements reformatted from single-line to multi-line prop layout, preserving the same variant and className values.
CircleCheck/Flag/Bolt/CheckboxIcon JSX reformatting
apps/web/app/(ee)/app.dub.co/.../rewards/form.tsx, apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/submission-fields.tsx, apps/web/app/(ee)/partners.dub.co/.../success/page.tsx, apps/web/app/app.dub.co/.../links/*.tsx, apps/web/app/app.dub.co/(onboarding)/.../reward/form.tsx, apps/web/ui/modals/link-conversion-tracking-modal.tsx, apps/web/ui/partners/discounts/add-edit-discount-sheet.tsx, apps/web/ui/partners/fraud-risks/partner-risk-indicator.tsx, apps/web/ui/shared/password-requirements.tsx, packages/ui/src/card-selector.tsx, packages/ui/src/combobox/index.tsx
CircleCheck, Flag, Bolt, and CheckboxIcon JSX usages reformatted to multi-line prop layout; a combobox import statement is also condensed to single line.
Nucleo SVG icon markup reformatting
packages/ui/src/icons/nucleo/*.tsx
SVG path/circle/line/rect/polygon/polyline attribute layouts reflowed inside variant conditionals across many icon files, preserving identical d values and attributes.
Zod schema describe reformatting
apps/web/lib/zod/schemas/partners.ts
The search field's .describe(...) string reformatted from single-line to multiline, preserving the described text.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • dubinc/dub#4134: Changes the same BadgeCheck2/CircleCheck/Bolt icon call sites to the new variant="fill" API, overlapping with the same usages reformatted here.

Suggested reviewers: steven-tey, pepeladeira

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the PR’s main change: formatting icon component usage and nucleo icon definitions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devkiran
devkiran requested a review from steven-tey July 8, 2026 10:39
@devkiran
devkiran merged commit 4a1ed2e into main Jul 8, 2026
12 checks passed
@devkiran
devkiran deleted the format branch July 8, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant