Avoid skipping a minute when system is under heavy load. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 31, 2015 14:09
…unning. (We have long running cronjobs...)
robdewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid skipping a minute when system is under heavy load.
In fact this is just a hack on a weird part of code. I would expect this to work by calculating the number of seconds until the next minute just before the end of the loop, and then wait that calculated time directly after that. But this is not how the code works. Somehow this is done in the code by getting the current time at the start of the loop. Then, while in the loop, stuff happens (which takes time) and even a sleep(5) is done, but none of this is accounted for in the calculation of the sleep-time.
Maybe I am missing something, so I just lowered the (large) wait-time. Theoretically, the same thing can still happen if the calls in the loop take more than 30 seconds, but we'll settle for that.