Skip to content

Remove unused manifest version field#26

Merged
dubsector merged 1 commit into
mainfrom
chore/remove-unused-manifest-version
Jul 5, 2026
Merged

Remove unused manifest version field#26
dubsector merged 1 commit into
mainfrom
chore/remove-unused-manifest-version

Conversation

@dubsector

Copy link
Copy Markdown
Owner

Summary

  • Neither Windows nor Android's Chromium PWA installers read the manifest `version` field for their app-listing version display — both hardcode 1/1.0 regardless of manifest content (confirmed by building locally and inspecting `dist/manifest.webmanifest`, which had the correct date-based value, and by checking an installed instance on both platforms).
  • Removes `getBuildVersion()` and the manifest `version` field along with its `@ts-expect-error` workaround, since it wasn't accomplishing anything.
  • The in-app footer's build date/commit stamp (`BUILD_INFO`) is untouched — that one is visible and works.

Test plan

  • `npm run build` succeeds, `dist/manifest.webmanifest` no longer has a `version` key
  • Verified in preview: app loads, no console errors, footer build info unchanged

Neither Windows nor Android's PWA installers read the manifest's
version field for their app-listing version display (both just show
1/1.0 regardless), so the date-stamping code wasn't accomplishing
anything and just needed a @ts-expect-error workaround to exist.
@dubsector
dubsector merged commit fc274aa into main Jul 5, 2026
4 checks passed
@dubsector
dubsector deleted the chore/remove-unused-manifest-version branch July 5, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant