Fix update prompt not applying on reload#28
Merged
Merged
Conversation
registerType is 'prompt', so vite-plugin-pwa never enables clientsClaim (that only happens for registerType 'autoUpdate'). Without it, calling skipWaiting() activates the new worker but never hands control of already-open tabs to it, so the controllerchange event the update prompt waits on to reload never fires - the button looked broken on both desktop and mobile. Also restores the SKIP_WAITING message listener that generateSW used to add automatically, now that sw.ts is hand-written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan