Add generated Android TWA project and fix build workflow#29
Merged
Conversation
The project is generated via 'bubblewrap update' (not 'init', which requires an interactive wizard that crashes on non-TTY stdin in this bubblewrap/Node combination) reading android/twa-manifest.json, which replaces the old placeholder at the repo root. Along the way: enableNotifications was set to false since we don't use push notifications, but that flag also gates whether the DelegationService - which handles share-target routing, not just notifications - is enabled/exported at all. Left it on. android-build.yml previously called 'bubblewrap init' every run, which needs a --manifest URL and generates a fresh project from scratch rather than using the committed one. Now it just runs 'bubblewrap build' against the committed project, with the Android SDK provided by android-actions/setup-android and the keystore passed via --signingKeyPath/--signingKeyAlias instead of mutating the manifest file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
android/, replacing the placeholdertwa-manifest.jsonfrom Add Web Share Target support and Android AAB build workflow #27 with a real, validated one atandroid/twa-manifest.jsonbubblewrap update(notinit, which requires an interactive wizard that crashes withERR_USE_AFTER_CLOSEon non-TTY stdin in this bubblewrap/Node combination) reading the committed manifest directlyenableNotifications: falsealso disables/un-exports theDelegationService, which is what handles Web Share Target routing, not just push notifications — left it enabledandroid-build.yml: it previously ranbubblewrap initon every trigger, which needs a--manifestURL and generates a fresh project from scratch rather than using the committed one. Now it runsbubblewrap buildagainst the committed project, gets its Android SDK fromandroid-actions/setup-android, and passes the keystore via--signingKeyPath/--signingKeyAliasflags instead of mutating the manifest fileAndroidManifest.xmlcontains a correctSEND/SEND_MULTIPLEintent-filter for our declared video MIME types, and theMETADATA_SHARE_TARGETmeta-data pointing at the share_target JSONTest plan
android/twa-manifest.jsonschema matches Bubblewrap's actualTwaManifestJsontype (verified against source)bubblewrap updatelocally, confirmed successful non-interactive project generationAndroidManifest.xml's share-target intent-filter andDelegationServiceconfigBuild Android AABworkflow and confirm it produces a signed.aabin CI (untested — local Windows Gradle invocation hit environment-specific issues unrelated to the Linux CI environment this workflow actually runs in)