Write upper and lower bounds for most primitive types to manifest files #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te them as little (or big?) endian blobs
…e, float, date and teimstamp
…hecked against spark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implements the writing of upper and lower bounds values to manifest files. This can help other readers filter on bounds.
Upper and lower bounds for nested types is skipped here.
Still need to figure out testing, if spark has a different thread count for writing tables, the data files are different, and then our tests that assume a specific thread count fail. Upper and lower bound values test needs 1 thread to test max and min values, but that has an effect of other spark written tables, hence some of the failures