Skip to content

Conversation

lhofhansl
Copy link
Contributor

@lhofhansl lhofhansl commented Oct 7, 2024

I realize that one use the Appender instead, but I did notice that we force a transaction per row even when auto-commit is off.

This uses a transaction per batch instead. Looks like this is already covered in the tests, please let me know if you think that's not sufficient.

Roughly a 2x improvement in tests (this is a using DuckDB from Trino).

@hannes hannes merged commit b2ff18a into duckdb:main Oct 14, 2024
7 checks passed
@hannes
Copy link
Member

hannes commented Oct 14, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants