Correct type mappings for .NET numeric types #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR correct the type mapping changing the ODBC type to `SQL_DECIMAL` for the following DuckDB types: - `UBIGINT` - `HUGEINT` - `UHUGEINT` - `DECIMAL` .NET CLS type for these DB types is now `System.Decimal`. Testing: new test-suite is added using `dotnet` on Linux. Currently it only covers the type mapping from `OdbcConnection` to .NET CLS types. It overlaps with existing Windows `dotnet` test-suite, but it appeared challenging to iterate over Windows `dotnet` due to long compile times on Windows. New test-suite is confirmed to work on Ubuntu-22.04 and Fedora. It is added to `ODBC Tests` CI run. Fixes: duckdb#93
maiadegraaf
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correct the type mapping changing the ODBC type to
SQL_DECIMALfor the following DuckDB types:UBIGINTHUGEINTUHUGEINTDECIMAL.NET CLS type for these DB types is now
System.Decimal.Testing: new test-suite is added using
dotneton Linux. Currently it only covers the type mapping fromOdbcConnectionto .NET CLS types. It overlaps with existing Windowsdotnettest-suite, but it appeared challenging to iterate over Windowsdotnetdue to long compile times on Windows. New test-suite is confirmed to work on Ubuntu-22.04 and Fedora. It is added toODBC TestsCI run.Fixes: #93