Add optional client id upon attach#183
Open
ccfelius wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of multiple PRs to implement reconnects - extensive explanation in https://github.com/duckdblabs/duckdb-internal/issues/9576.
This PR adds the possibility to manually pass a
client_id. The client optionally passes a client_id string when attaching:ATTACH {server} AS remote (token 'asdf', client_id 'random_client_id'). This client_id is propagated to the server, along with a token.After successful authentication the server then computes a hash(session_id + token + client_id), since these 3 values produce a different hash for each server/token. This is stored in a
QuackConnection, and the hash is exposed in thequack_active_connections().This could also be useful for e.g. logging, since this makes tracking a specific client more explicit. But this should be added to the logger.