Add duckdb_arrow_scan

.github/workflows/rust.yaml

@@ -8,118 +8,8 @@ on:
 env:
   RUST_BACKTRACE: 1
 jobs:
-  test:
-    name: Test ${{ matrix.target }}
-    strategy:
-      fail-fast: true
-      matrix:
-        include:
-          - { target: x86_64-pc-windows-msvc, os: windows-latest, duckdb: libduckdb-windows-amd64.zip }
-          - { target: x86_64-unknown-linux-gnu, os: ubuntu-latest, duckdb: libduckdb-linux-amd64.zip }
-          #- { target: x86_64-apple-darwin, os: macos-latest }
-          #- {
-              #target: x86_64-pc-windows-gnu,
-              #os: windows-latest,
-              #host: -x86_64-pc-windows-gnu,
-            #}
-
-    runs-on: ${{ matrix.os }}
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions-rust-lang/setup-rust-toolchain@v1
-        with:
-          toolchain: stable
-          target: ${{ matrix.target }}
-          components: 'rustfmt, clippy'
-
-      # download libduckdb
-      - uses: robinraju/[email protected]
-        name: Download duckdb
-        with:
-          repository: "duckdb/duckdb"
-          tag: "v1.2.1"
-          fileName: ${{ matrix.duckdb }}
-          out-file-path: .
-
-      # For Linux
-      - name: Linux extract duckdb
-        if: matrix.os == 'ubuntu-latest'
-        uses: ihiroky/extract-action@v1
-        with:
-          file_path: ${{ github.workspace }}/${{ matrix.duckdb }}
-          extract_dir: libduckdb
-
-      - run: cargo fmt --all -- --check
-        if: matrix.os == 'ubuntu-latest'
-
-      - name: run cargo clippy
-        if: matrix.os == 'ubuntu-latest'
-        env:
-          DUCKDB_LIB_DIR: ${{ github.workspace }}/libduckdb
-          DUCKDB_INCLUDE_DIR: ${{ github.workspace }}/libduckdb
-          LD_LIBRARY_PATH: ${{ github.workspace }}/libduckdb
-        run: |
-          cargo clippy --all-targets --workspace --all-features -- -D warnings -A clippy::redundant-closure
-
-
-      # For windows
-      - name: Windows extract duckdb
-        if: matrix.os == 'windows-latest'
-        uses: DuckSoft/[email protected]
-        with:
-          pathSource: D:\a\duckdb-rs\duckdb-rs\${{ matrix.duckdb }}
-          pathTarget: ${{ github.workspace }}/libduckdb
-
-      - name: Add path to PATH environment variable
-        if: matrix.os == 'windows-latest'
-        uses: myci-actions/export-env-var-powershell@1
-        with:
-          name: PATH
-          value: $env:PATH;${{ github.workspace }}/libduckdb
-
-      - name: Run cargo-test
-        if: matrix.os == 'windows-latest'
-        run: cargo test --features "modern-full vtab-full vtab-loadable"
-        env:
-          DUCKDB_LIB_DIR: ${{ github.workspace }}/libduckdb
-          DUCKDB_INCLUDE_DIR: ${{ github.workspace }}/libduckdb
-
-      - name: Build loadable extension
-        run: cargo build --example hello-ext --features="vtab-loadable"
-        env:
-          DUCKDB_LIB_DIR: ${{ github.workspace }}/libduckdb
-          DUCKDB_INCLUDE_DIR: ${{ github.workspace }}/libduckdb
-          LD_LIBRARY_PATH: ${{ github.workspace }}/libduckdb
-
-      - name: Build loadable extension
-        run: cargo build --example hello-ext-capi --features="vtab-loadable loadable-extension"
-        env:
-          DUCKDB_LIB_DIR: ${{ github.workspace }}/libduckdb
-          DUCKDB_INCLUDE_DIR: ${{ github.workspace }}/libduckdb
-          LD_LIBRARY_PATH: ${{ github.workspace }}/libduckdb
-
-  Windows:
-    name: Windows build from source
-    needs: test
-    runs-on: windows-latest
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/cache@v3
-        with:
-          path: ~/.cargo/registry/index
-          key: index-${{ runner.os }}-${{ github.run_number }}
-          restore-keys: |
-            index-${{ runner.os }}-
-      - uses: actions-rust-lang/setup-rust-toolchain@v1
-        with:
-          toolchain: stable
-          target: x86_64-pc-windows-msvc
-
-      - run: cargo install cargo-examples
-
   Sanitizer:
     name: Address Sanitizer
-    needs: test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -128,12 +18,14 @@ jobs:
         with:
           toolchain: nightly
           components: 'rust-src'
-
+      - name: Install LLVM
+        run: |
+          sudo apt-get install -y llvm
       - name: Tests with asan
         env:
           RUSTFLAGS: -Zsanitizer=address -C debuginfo=0
           RUSTDOCFLAGS: -Zsanitizer=address
-          ASAN_OPTIONS: "detect_stack_use_after_return=1:detect_leaks=1"
+          ASAN_OPTIONS: "detect_stack_use_after_return=1:detect_leaks=1:symbolize=1"
           # Work around https://github.com/rust-lang/rust/issues/59125 by
           # disabling backtraces. In an ideal world we'd probably suppress the
           # leak sanitization, but we don't care about backtraces here, so long
@@ -142,6 +34,8 @@ jobs:
         # We cannot run "modern-full" with asan as the chrono feature will auto-load relase binaries of
         # the ICU-extension, which are not built with ASAN and will cause a crash.
         run: |
+          export ASAN_SYMBOLIZER_PATH=$(which llvm-symbolizer)
+          echo $ASAN_SYMBOLIZER_PATH
           cargo -Z build-std test --features "serde_json url r2d2 uuid polars extensions-full" --target x86_64-unknown-linux-gnu --package duckdb
       - name: publish crates --dry-run
         uses: katyo/publish-crates@v2

crates/duckdb/src/appender_params.rs

@@ -44,15 +44,15 @@ use sealed::Sealed;
 ///     - a reference to an array of references, as in `thing.query(&["foo",
 ///       "bar", "baz"])` or `thing.query(&[&1i32, &2, &3])`.
 ///
-///         (Note: in this case we don't implement this for slices for coherence
-///         reasons, so it really is only for the "reference to array" types —
-///         hence why the number of parameters must be <= 32 or you need to
-///         reach for `duckdb::params!`)
-///
-///     Unfortunately, in the current design it's not possible to allow this for
-///     references to arrays of non-references (e.g. `&[1i32, 2, 3]`). Code like
-///     this should instead either use `params!`, an array literal, a `&[&dyn
-///     ToSql]` or if none of those work, [`ParamsFromIter`].
+///       (Note: in this case we don't implement this for slices for coherence
+///       reasons, so it really is only for the "reference to array" types —
+///       hence why the number of parameters must be <= 32 or you need to
+///       reach for `duckdb::params!`)
+///
+///   Unfortunately, in the current design it's not possible to allow this for
+///   references to arrays of non-references (e.g. `&[1i32, 2, 3]`). Code like
+///   this should instead either use `params!`, an array literal, a `&[&dyn
+///   ToSql]` or if none of those work, [`ParamsFromIter`].
 ///
 /// - As a slice of `ToSql` trait object references, e.g. `&[&dyn ToSql]`. This
 ///   is mostly useful for passing parameter lists around as arguments without