fix: libduckdb-sys build fails on Windows#495
Merged
Conversation
|
In my testing, this PR resolves a portion of the issues. There are still some other errors: This error can be fixed by the following code (from AI): println!("cargo:rustc-link-lib=dylib=Rstrtmgr");
println!("cargo:rustc-link-lib=dylib=Bcrypt");For me, this resolved all the errors I was encountering while building libduckdb-sys on Windows. |
Contributor
Author
|
I found the following some lines in CMakeList.txt https://github.com/duckdb/duckdb/blob/7c039464e452ddc3330e2691d3fa6d305521d09b/src/CMakeLists.txt#L33 These lines add Ws2_32, Rstrtmgr and Bcrypt to the link targets when using MSVC. |
Member
|
Thanks! |
This was referenced Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix libduckdb-sys build failure on Windows related to #268 (possibly also related to #482 and #413).
Added a line to libduckdb-sys/build.rs to specify the encoding when compiling C code.