Skip to content

Fix a bunch of problems reported by Clippy#517

Merged
Maxxen merged 6 commits into
duckdb:mainfrom
mlafeldt:clippy-fixes
Jun 19, 2025
Merged

Fix a bunch of problems reported by Clippy#517
Maxxen merged 6 commits into
duckdb:mainfrom
mlafeldt:clippy-fixes

Conversation

@mlafeldt
Copy link
Copy Markdown
Member

@mlafeldt mlafeldt commented Jun 18, 2025

I noticed the following warning in CI, which is only reported by Rust nightly:

[Address Sanitizer: crates/duckdb/src/row.rs#L346](https://github.com/duckdb/duckdb-rs/pull/516/files#annotation_35818535305)
lifetime flowing from input to output with different syntax can be confusing

One thing led to another, and I fixed a bunch of clippy warnings as a result. 😎

cargo build and cargo clippy now work fine using both Rust stable and nightly.

@mlafeldt mlafeldt requested a review from Maxxen June 18, 2025 14:23
@mlafeldt mlafeldt self-assigned this Jun 18, 2025
@Maxxen
Copy link
Copy Markdown
Member

Maxxen commented Jun 19, 2025

Looks great!

@Maxxen Maxxen merged commit b45c467 into duckdb:main Jun 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants